fix(next): some openapi-codegen args are ignored #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Thanks for contributing @darai0512, sorry this slipped through the cracks! Left a comment on the api_docs_url option - I also think the out option is not particularly useful since there's no reason that out directly would ever clash with something a user already has. So would be happy to remove that as well (maybe could replace usage of "out" with a constant), instead of adding complexity with making Command globally accessible.
| let unprefixed_link = self.doc_links.get(object)?; | ||
| Some(format!("https://stripe.com/docs/api{}", unprefixed_link)) | ||
| Some(format!("{}{}", args.api_docs_url, unprefixed_link)) |
There was a problem hiding this comment.
There was a bunch of churn at some point around how Stripe structured their docs and a bunch of the handling for this stuff changed. I think this argument is a relic of that and the option can just be safely removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some arguments of openapi-codegen (especially
outandapi_docs_url) are ignored on next branch. So, try to fix it.(This problem & PR are not significant. I think next branch is under development, and you may have better ideas. If this change is unnecessary, please close this.)
(I think it is better to use lazy_static for
Command::parse().)Checklist