Fixed infinite loop on list pagination when the result had more than 1 item #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for taking the time to sort this silly bug. CI is running and I will get a release out when it is ready. |
|
Hope you don't mind I took the time to fix the trivial sync issue and add a test for it. Thanks for putting this together! |
|
Thanks for merging it! Would you mind publishing a new version with this fixed on crates.io? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
cargo make fmtfix: Fixed infinite loop on list pagination when the result had more than 1 item
I also added tests with 2 elements, so this never happens again.
What was happening:
The
get_dataimplementations ofPaginableListwas cloning the data every single time.When the data was "popped" in the
unfold_streamfunction, it was popping from the cloned vector.Specifically the
if paginator.page.data.len() > 1 { ...as with anything less than than 2 elements, the condition was false and it either ended the stream or requested the next page.