Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing byn and mmk currency in the Currency enum #460

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

BentEngbers
Copy link
Contributor

@BentEngbers BentEngbers commented Dec 12, 2023

Summary

fixes #459

Checklist

  • ran cargo make fmt
    (Most of the changes come from fmt)
  • using conventional commits to hightlight user-facing fixes and features

TO DECIDE:

  • We could use serde rename_all to rename all enum values to lower-case in the Currency Enum. I would be happy to implement this.

@BentEngbers BentEngbers changed the title Update currency.rs Add missing byn and mmk currency in the Currency enum Dec 12, 2023
@arlyon
Copy link
Owner

arlyon commented Jan 5, 2024

Running CI, thanks!

@arlyon
Copy link
Owner

arlyon commented Jan 10, 2024

Hello, we had some conflicts with our dependencies moving out from underneath us. I have fixed that now, so if you are able to rebase I will get this merged for you! 🎉

@arlyon
Copy link
Owner

arlyon commented Jan 24, 2024

I have rebased this for you, will merge once CI goes

@arlyon arlyon merged commit 7036ab3 into arlyon:master Jan 24, 2024
16 checks passed
@BentEngbers BentEngbers deleted the patch-1 branch January 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The byn and mmk currency is missing in the Currency enum
2 participants