Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module resources not public #614

Closed
matjazonline opened this issue Sep 23, 2024 · 1 comment · Fixed by #615
Closed

module resources not public #614

matjazonline opened this issue Sep 23, 2024 · 1 comment · Fixed by #615
Labels
bug Something isn't working released

Comments

@matjazonline
Copy link

Describe the bug

CheckoutSession::retrieve_line_items(...) uses param &RetrieveCheckoutSessionLineItems which is not public and can't be used.

To Reproduce

Using RetrieveCheckoutSessionLineItems can't build:

use stripe::resources::checkout::checkout_session_ext::RetrieveCheckoutSessionLineItems;

Expected behavior

RetrieveCheckoutSessionLineItems would be available outside library like

use stripe::resources::checkout::checkout_session_ext::RetrieveCheckoutSessionLineItems;

Code snippets

No response

OS

macos

Rust version

v1.81.0

Library version

0.39.1

API version

2024-06-20

Additional context

No response

@matjazonline matjazonline added the bug Something isn't working label Sep 23, 2024
augustoccesar added a commit to augustoccesar/async-stripe that referenced this issue Sep 24, 2024
### Description
Currently, the `checkout_session_ext` is not being exported, which makes the `RetrieveCheckoutSessionLineItems` not being able to be used.

With this change, the following should now be possible:
```rust
use std::str::FromStr;

use stripe::{CheckoutSession, CheckoutSessionId, Client, RetrieveCheckoutSessionLineItems};

#[tokio::main]
async fn main() {
    let secret_key = std::env::var("STRIPE_SECRET_KEY").expect("Missing STRIPE_SECRET_KEY in env");
    let client = Client::new(secret_key);

    let _line_items = CheckoutSession::retrieve_line_items(
        &client,
        &CheckoutSessionId::from_str("").unwrap(),
        &RetrieveCheckoutSessionLineItems::default(),
    )
    .await
    .unwrap();
}
```

Closes arlyon#614
augustoccesar added a commit to augustoccesar/async-stripe that referenced this issue Sep 24, 2024
### Description
Currently, the `checkout_session_ext` is not being exported, which makes the `RetrieveCheckoutSessionLineItems` not being able to be used.

With this change, the following should now be possible:
```rust
use std::str::FromStr;

use stripe::{CheckoutSession, CheckoutSessionId, Client, RetrieveCheckoutSessionLineItems};

#[tokio::main]
async fn main() {
    let secret_key = std::env::var("STRIPE_SECRET_KEY").expect("Missing STRIPE_SECRET_KEY in env");
    let client = Client::new(secret_key);

    let _line_items = CheckoutSession::retrieve_line_items(
        &client,
        &CheckoutSessionId::from_str("").unwrap(),
        &RetrieveCheckoutSessionLineItems::default(),
    )
    .await
    .unwrap();
}
```

Closes arlyon#614
@arlyon arlyon closed this as completed in e4e7220 Sep 26, 2024
arlyon pushed a commit that referenced this issue Sep 26, 2024
# [0.40.0](v0.39.2...v0.40.0) (2024-09-26)

### Features

* export checkout_session_ext ([e4e7220](e4e7220)), closes [#614](#614)
@arlyon
Copy link
Owner

arlyon commented Sep 26, 2024

🎉 This issue has been resolved in version 0.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

risha700 pushed a commit to risha700/async-stripe that referenced this issue Oct 7, 2024
### Description
Currently, the `checkout_session_ext` is not being exported, which makes the `RetrieveCheckoutSessionLineItems` not being able to be used.

With this change, the following should now be possible:
```rust
use std::str::FromStr;

use stripe::{CheckoutSession, CheckoutSessionId, Client, RetrieveCheckoutSessionLineItems};

#[tokio::main]
async fn main() {
    let secret_key = std::env::var("STRIPE_SECRET_KEY").expect("Missing STRIPE_SECRET_KEY in env");
    let client = Client::new(secret_key);

    let _line_items = CheckoutSession::retrieve_line_items(
        &client,
        &CheckoutSessionId::from_str("").unwrap(),
        &RetrieveCheckoutSessionLineItems::default(),
    )
    .await
    .unwrap();
}
```

Closes arlyon#614
risha700 pushed a commit to risha700/async-stripe that referenced this issue Oct 7, 2024
# [0.40.0](arlyon/async-stripe@v0.39.2...v0.40.0) (2024-09-26)

### Features

* export checkout_session_ext ([e4e7220](arlyon@e4e7220)), closes [arlyon#614](arlyon#614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants