Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs are not building on docs.rs #333

Closed
valkum opened this issue Feb 1, 2023 · 1 comment · Fixed by #337
Closed

Docs are not building on docs.rs #333

valkum opened this issue Feb 1, 2023 · 1 comment · Fixed by #337
Labels
bug Something isn't working

Comments

@valkum
Copy link

valkum commented Feb 1, 2023

Describe the bug

Due to rust-lang/cargo#10343, the cargo args for docs.rs need to be removed.
Also rustdoc-scrape-examples is now enabled by default on docs.rs: rust-lang/docs.rs#1954

To Reproduce

Look at https://docs.rs/crate/async-stripe/0.15.1

Expected behavior

Successful build

Code snippets

No response

OS

n/a

Rust version

n/a

Library version

0.15.1

API version

n/a

Additional context

No response
@valkum valkum added the bug Something isn't working label Feb 1, 2023
@arlyon
Copy link
Owner

arlyon commented Feb 2, 2023

Thanks for raising this. I'll get it sorted!

arlyon added a commit that referenced this issue Feb 4, 2023
@arlyon
remove cargo args
5fb67cb 
Closes #333. Rustdoc examples scraping is now turned on by default. rust-lang/docs.rs#1954
@arlyon arlyon mentioned this issue Feb 4, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove cargo args arlyon/async-stripe
2 participants
@valkum @arlyon