Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rand to 0.8 and remove rand_xorshift #24

Closed
wants to merge 2 commits into from
Closed

Bump rand to 0.8 and remove rand_xorshift #24

wants to merge 2 commits into from

Conversation

weikengchen
Copy link
Member

This is currently a draft PR, since there are still a number of libraries in arkworks-rs that needs to be adjusted to ark_std::rand, including the public repos crypto-primitives, curves, pcd and some private repos.

Since we have test_rng, it is planned to retire rand_xorshift.

@weikengchen weikengchen marked this pull request as draft February 5, 2021 02:47
@Pratyush
Copy link
Member

btw @weikengchen , any updates on this?

@weikengchen
Copy link
Member Author

Let me do a final pass on existing repos under arkworks.

@weikengchen
Copy link
Member Author

All repos in arkworks have been modified, and I think it is ready to bump the version.

Note that after this PR, some post-merging actions are needed---I doubt rand_chacha 0.2 would work for rand 0.8, and we may need to bump it to rand_chacha 0.3 after this PR.

@weikengchen weikengchen marked this pull request as ready for review March 24, 2021 05:04
@weikengchen
Copy link
Member Author

Since I don't have write access to this repo and it seems that this PR needs to sync with the master updates...I would leave this one to @Pratyush for a final pass.

@weikengchen
Copy link
Member Author

(Bump)

@weikengchen
Copy link
Member Author

Let me close this one and recreate it (the conflicts cannot be resolved in the web editor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants