Add into_inner function for ConstraintSystemRef<F>
#347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Question: the comment said that it "panics if any other references to From the code, it panics in the case when |
|
Maybe just have the method return an Option? That way the decision to panic is left to users |
|
I think going with an option is better as well |
Pratyush
reviewed
Apr 10, 2021
| /// `Self::CS` exist. | ||
| pub fn into_inner(self) -> Option<ConstraintSystem<F>> { | ||
| match self { | ||
| Self::CS(a) => Some(Rc::try_unwrap(a).unwrap().into_inner()), |
There was a problem hiding this comment.
Shouldn’t this just use a map?
There was a problem hiding this comment.
Updated with map in 1cfae51. Have to use a clone on Rc but I guess it should be okay.
|
Ready for a final pass. |
Pratyush
reviewed
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a helper function to unwrap a
ConstraintSystemRef<F>. This is useful for managing memory in arkworks-rs/marlin#71.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer