Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl CanonicalSerde for Powers, and PartialEq for params and keys #84

Merged
merged 5 commits into from
Aug 5, 2021
Merged

impl CanonicalSerde for Powers, and PartialEq for params and keys #84

merged 5 commits into from
Aug 5, 2021

Conversation

zhenfeizhang
Copy link
Contributor

@zhenfeizhang zhenfeizhang commented Aug 3, 2021

Description

  • adding serdes for Powers
  • allow the callers to derive PartialEq for UniversalParams and VerifierKey

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Re-reviewed Files changed in the Github PR explorer

not relevant

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md

@weikengchen
Copy link
Member

just one quick question related to the PR:

so the PartialEq is added for serialization?

@alxiong
Copy link
Contributor

alxiong commented Aug 4, 2021

No, PartialEq is for accompanying auto-derived Hash trait, motivated by cases where consistent hashing of the verifying key is needed.

For example, the predicate identifier in zexe: pid = H(vk)

Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo these small changes

@zhenfeizhang
Copy link
Contributor Author

Thanks, and fixed.

@Pratyush
Copy link
Member

Pratyush commented Aug 4, 2021

btw, for the hashing, you should note that the Hash trait in std is not for cryptographic hashing.

@Pratyush Pratyush changed the title enabling serde for Powers; PartialEq for params and keys impl CanonicalSerde for Powers, and PartialEq for params and keys Aug 5, 2021
@Pratyush Pratyush merged commit cafc05e into arkworks-rs:master Aug 5, 2021
@zhenfeizhang zhenfeizhang deleted the patch-kzg10-serde-0.3.0 branch August 5, 2021 17:42
nmohnblatt added a commit to geometryxyz/poly-commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants