-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl CanonicalSerde
for Powers
, and PartialEq
for params and keys
#84
impl CanonicalSerde
for Powers
, and PartialEq
for params and keys
#84
Conversation
just one quick question related to the PR: so the PartialEq is added for serialization? |
No, For example, the predicate identifier in zexe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo these small changes
Thanks, and fixed. |
btw, for the hashing, you should note that the |
CanonicalSerde
for Powers
, and PartialEq
for params and keys
…s and keys (arkworks-rs#84)" This reverts commit cafc05e.
Description
serdes
forPowers
PartialEq
forUniversalParams
andVerifierKey
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changed
in the Github PR explorernot relevant
Pending
section inCHANGELOG.md