Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft comparison between MarlinPC and SonicPC #83

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Jul 29, 2021

Description

This is a draft version of the comparison between MarlinPC and SonicPC, with some additional information extracted from the individual modules, so it can server as a README for the src directory.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Re-reviewed Files changed in the Github PR explorer

N/A:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Updated relevant documentation in the code

@weikengchen weikengchen added T-documentation Type: doc improvements help wanted labels Jul 29, 2021
@weikengchen weikengchen requested a review from Pratyush July 29, 2021 02:22
src/README.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
@Pratyush Pratyush merged commit b699545 into master Aug 4, 2021
@Pratyush Pratyush deleted the add-comparison branch August 4, 2021 21:23
nmohnblatt added a commit to geometryxyz/poly-commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-documentation Type: doc improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants