Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MarlinPC's CommitterKey to return the correct supported_degree #78

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

Will-Lin4
Copy link
Contributor

Description

Fixes MarlinPC's CommitterKey supported_degree function to return the correct degree from the number of powers. The number of elements in powers is equal to supported_degree + 1, as specified in the trim function here:

let powers = pp.powers_of_g[..=supported_degree].to_vec();


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [NA] Wrote unit tests (Existing unit tests use supported_degree already to generate polynomials)
  • [NA] Updated relevant documentation in the code (Existing documentation is sufficient)
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Will-Lin4 Will-Lin4 requested a review from Pratyush April 10, 2021 20:54
@weikengchen weikengchen merged commit 3b88b97 into master Apr 11, 2021
@weikengchen weikengchen deleted the fix-marlinpc-supported-degree branch April 11, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants