Improve trait implementations for algebraic hashes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to merge or is it still ongoing? If so, I can merge after the lint checks pass. |
|
This is ready to merge. I've fixed the clippy warnings that pertained to this work, but the rest of them are entirely unrelated and looking at PR history they've been failing for quite some time now. |
|
I see, will fix them in an other PR and merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues related to missing or wrong trait implementations, that make it impossible to work with algebraic hashes:
FieldChallengesto use units whenever possible. Previously even own-field challenges would go through the bytes impl for no apparent reason;ByteReaderandByteWriterfor field-based transcripts.