Add the SNARK gadget traits #2
Conversation
|
(still adding comments) |
|
ready for more review |
src/snark/constraints.rs
Outdated
| // the same routine as the new_input above | ||
|
|
There was a problem hiding this comment.
If it's the same routine, then can we reuse the implementation to avoid duplication and things going out of sync?
src/snark/constraints.rs
Outdated
| // the same routine as the new_input above. | ||
|
|
There was a problem hiding this comment.
Same comment: can we share the impl between the two methods?
| fn from_field_elements(src: &Vec<FpVar<CF>>) -> Result<Self, SynthesisError> { | ||
| // the same routine as the new_input above. | ||
|
|
||
| let cs = src.cs(); |
There was a problem hiding this comment.
You probably want to handle the case of constants separately from variables (in the former I guess you don't do any constraint generation?)
Co-authored-by: Pratyush Mishra <[email protected]>
Co-authored-by: Pratyush Mishra <[email protected]>
|
Will get back to this in one hour. |
|
Not an easy one. For those "the same routine as the new_input above", I read the code and agree there are some overlapping, but it seems hard to extract some common elements that make a lot of sense. So, I just expand the comments. I also changed the |
|
I think this is failing |
|
Thanks! |
|
All checks have passed now. |
Co-authored-by: Pratyush Mishra <[email protected]>
This PR adds the SNARK trait and the shared component Input Gadgets (will be used by Groth16 and GM17). And it fixes a few compilation errors.
The PR is not finished---there is an input gadget for nonnative fields, which is required for Marlin. We will wait for the dependency.