Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo changes in 0960300 #154

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Undo changes in 0960300 #154

merged 2 commits into from
Oct 23, 2024

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Oct 22, 2024

The changes in commit 0960300 were to satisfy CI for the nightly build. It is no longer an issue. Also, it is better to bring the struct IdentityDigestConverter back as some users depend on it.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner October 22, 2024 15:37
@autquis autquis requested review from z-tech, mmagician and tyshko-rostyslav and removed request for a team October 22, 2024 15:37
@Pratyush Pratyush added this pull request to the merge queue Oct 23, 2024
Merged via the queue into arkworks-rs:main with commit 6a770eb Oct 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants