Remove unneeded permute from Poseidon hashing #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the implementation of Poseidon permuted on every absorb, and only a subset of the squeezes. This resulted in 2x the number of constraints in comparison to the Neptune implementation.
The Neptune implementation permutes on absorb only when the absorb position is equivalent to the rate. And it instead permutes on every squeeze after an absorb and when the position is equivalent to the rate.
After speaking with @Pratyush, modified the arkworks sponge to have the same permutation pattern.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer