Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded permute from Poseidon hashing #152

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

ecmargo
Copy link
Contributor

@ecmargo ecmargo commented Oct 10, 2024

Description

Previously, the implementation of Poseidon permuted on every absorb, and only a subset of the squeezes. This resulted in 2x the number of constraints in comparison to the Neptune implementation.

The Neptune implementation permutes on absorb only when the absorb position is equivalent to the rate. And it instead permutes on every squeeze after an absorb and when the position is equivalent to the rate.

After speaking with @Pratyush, modified the arkworks sponge to have the same permutation pattern.


  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ecmargo ecmargo requested a review from a team as a code owner October 10, 2024 19:53
@ecmargo ecmargo requested review from z-tech, Pratyush and mmagician and removed request for a team October 10, 2024 19:53
@Pratyush Pratyush requested a review from weikengchen October 11, 2024 00:20
@Pratyush Pratyush enabled auto-merge October 16, 2024 19:11
auto-merge was automatically disabled October 16, 2024 19:14

Head branch was pushed to by a user without write access

@ecmargo ecmargo requested a review from Pratyush October 16, 2024 19:20
@Pratyush Pratyush added this pull request to the merge queue Oct 16, 2024
Merged via the queue into arkworks-rs:main with commit e51fc42 Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants