Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and build for each feature #142

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Apr 7, 2024

Before this fix and after #141, if you run

cargo build --no-default-features --features merkle_tree

you will get some errors. With this PR, we fix the imports for Vec in case of no-std.

Also, we changed CI to have different features so that we catch this kind of issue later.

depends on: #141


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner April 7, 2024 18:23
@autquis autquis requested review from z-tech, mmagician and weikengchen and removed request for a team April 7, 2024 18:23
@autquis
Copy link
Contributor Author

autquis commented Apr 7, 2024

Also, once the changes are approved and before the merge, I would like to do some cleanup for the imports of the repo.

needed after arkworks-rs/algebra#811

Need to add Sync trait bounds on a few types
Copy link
Member

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but since it includes my own changes from the other PR, I want to give others a chance to review before merging

Copy link

@z-tech z-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me

@mmagician mmagician added this pull request to the merge queue Apr 9, 2024
Merged via the queue into arkworks-rs:main with commit 9ef1753 Apr 9, 2024
5 checks passed
@mmagician mmagician deleted the fix-build-features-ci branch April 9, 2024 07:30
@mmagician mmagician mentioned this pull request Apr 9, 2024
6 tasks
@autquis
Copy link
Contributor Author

autquis commented Apr 9, 2024

Well, it seems now that I have to open another PR for cleaning up the imports. :D

@mmagician
Copy link
Member

Hmm really, I thought this one was also doing that.
Shall we reopen the other PR I closed, would that help?

@autquis
Copy link
Contributor Author

autquis commented Apr 9, 2024

I can do it on the closed PR, but it's same as opening a new one. Which one should I proceed with?

@mmagician
Copy link
Member

Ah no nvm, I thought your import fixed were either here or on the other closed PR. Then new one pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants