-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI and build for each feature #142
Conversation
Also, once the changes are approved and before the merge, I would like to do some cleanup for the imports of the repo. |
needed after arkworks-rs/algebra#811 Need to add Sync trait bounds on a few types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but since it includes my own changes from the other PR, I want to give others a chance to review before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me
Well, it seems now that I have to open another PR for cleaning up the imports. :D |
Hmm really, I thought this one was also doing that. |
I can do it on the closed PR, but it's same as opening a new one. Which one should I proceed with? |
Ah no nvm, I thought your import fixed were either here or on the other closed PR. Then new one pls |
Before this fix and after #141, if you run
you will get some errors. With this PR, we fix the imports for
Vec
in case ofno-std
.Also, we changed CI to have different features so that we catch this kind of issue later.
depends on: #141
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer