Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Fp code to use const generics, and more #379

Merged
merged 33 commits into from
Jan 31, 2022
Merged

Refactor Fp code to use const generics, and more #379

merged 33 commits into from
Jan 31, 2022

Commits on Jan 12, 2022

  1. const generics for Fp & no Montgomery default 

    * Switches from hardcoded `FpXYZ` to `Fp<N>` based on const generics.
* Moves Montgomery arithmetic to an optional backend
    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0b1c3c5 View commit details
    Browse the repository at this point in the history

  2. More powerful compile-time Fp configuration 

    * Rename `field_new` macros.
* Introduce `const fn`s for generating many constants.
* Add default associated constants to reduce boilerplate.
    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    56e5ecc View commit details
    Browse the repository at this point in the history

  3. Fix compilation errors in ark-ec

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    8a81ee7 View commit details
    Browse the repository at this point in the history

  4. Fix compilation errors in ark-poly

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    5fb6ffb View commit details
    Browse the repository at this point in the history

  5. Fix doctest

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    e8558d7 View commit details
    Browse the repository at this point in the history

  6. Fix CHANGELOG typos

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    2a47811 View commit details
    Browse the repository at this point in the history

  7. Everything compiles

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    fbede63 View commit details
    Browse the repository at this point in the history

  8. Rename Parameters to Config for all fields

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    7ea854b View commit details
    Browse the repository at this point in the history

  9. Update CHANGELOG and fix typos in README

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    dfeea4a View commit details
    Browse the repository at this point in the history

  10. Clean up CHANGELOG further

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    ec89e31 View commit details
    Browse the repository at this point in the history

  11. Fix assembly

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    cc8cb91 View commit details
    Browse the repository at this point in the history

  12. Fix indentation

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    266b37e View commit details
    Browse the repository at this point in the history

  13. Fix assembly

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    ad1bca7 View commit details
    Browse the repository at this point in the history

  14. Fix README lint

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    23868df View commit details
    Browse the repository at this point in the history

  15. Fix import

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    7a76bd8 View commit details
    Browse the repository at this point in the history

  16. Fix match statement

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    9ce6ce9 View commit details
    Browse the repository at this point in the history

  17. Fix match statement, and move no_carry check to constant

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b5f3887 View commit details
    Browse the repository at this point in the history

  18. Introduce BigInt macro

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    923bb3f View commit details
    Browse the repository at this point in the history

  19. Fix CAPACITY bug

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    61fcbaf View commit details
    Browse the repository at this point in the history

  20. Make QuadExt and CubicExt macros more succinct

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    2e083db View commit details
    Browse the repository at this point in the history

  21. Add documentation for macros

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    054204b View commit details
    Browse the repository at this point in the history

  22. fmt

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    a550389 View commit details
    Browse the repository at this point in the history

  23. Use singular in CHANGELOG 

    Co-authored-by: Weikeng Chen <[email protected]>
    @Pratyush @weikengchen
    Pratyush and weikengchen authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    5f866fe View commit details
    Browse the repository at this point in the history

  24. Clean up some documentation

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    2964946 View commit details
    Browse the repository at this point in the history

  25. Merge branch 'upgrade-ff' of github.com:arkworks-rs/algebra into upgr… 

    …ade-ff
    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    bce28d3 View commit details
    Browse the repository at this point in the history

  26. Update and format

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    5b6642f View commit details
    Browse the repository at this point in the history

  27. Clean up doc test

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    9f01c8b View commit details
    Browse the repository at this point in the history

  28. Clean up docs

    @Pratyush
    Pratyush committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0d8fcd1 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Weikeng Chen <[email protected]>
    @Pratyush @weikengchen
    Pratyush and weikengchen authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6f5623a View commit details
    Browse the repository at this point in the history

  2. Update ff/src/fields/mod.rs 

    Co-authored-by: Marcin <[email protected]>
    @Pratyush @mmagician
    Pratyush and mmagician authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    76b0084 View commit details
    Browse the repository at this point in the history

  3. Clean up and format

    @Pratyush
    Pratyush committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    b366b77 View commit details
    Browse the repository at this point in the history

  4. Remove FftConfig and move constants to FftField

    @Pratyush
    Pratyush committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    dc52c73 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG

    @Pratyush
    Pratyush committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    9ce092a View commit details
    Browse the repository at this point in the history