Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Slide mode and fixed to top #79

Closed
trzyna opened this issue May 9, 2017 · 9 comments
Closed

Slide mode and fixed to top #79

trzyna opened this issue May 9, 2017 · 9 comments
Labels
Milestone

Comments

@trzyna
Copy link

trzyna commented May 9, 2017

I noticed that when using push mode, the sidebar stays fixed and doesn't scroll. When using slide mode, it doesn't stay fixed to top. Is there a way to have it stay fixed with slide mode?

@Sifawm
Copy link

Sifawm commented May 18, 2017

I tried with the pull request #77 and it is ok. When you have push mode, the sidebar is fixed to top. When you have slide mode, not.

@arkon
Copy link
Owner

arkon commented May 20, 2017

This is a bit of a side effect of transform-ing the entire thing over when sliding, which causes the position: fixed to apply to that layer context instead of the body. I'll tag this as a bug for now, but I doubt this will be fixed anytime soon.

@arkon arkon added the bug label May 20, 2017
@lexcaraig
Copy link

lexcaraig commented Jun 9, 2017

any update on this?

My issue was when i use [mode]="push" nothing happens.

But i ended up using [mode]="mode[0]" and then in my component.ts is private mode: Array<string> = ['push']

Is there a way to just assign what mode you want? Thanks!

@arkon
Copy link
Owner

arkon commented Jun 9, 2017

@lexcaraig What do you mean nothing happens?

@jraaaaanger
Copy link

I'm seeing the same issue as @lexcaraig with [mode]="'push'". The content inside ng-sidebar-container is pushed over properly but the sidebar itself doesn't move at all, not totally sure why. [mode]="'slide'" works as expected.

@arkon unsure if these are related, should I open a new issue for this?

@arkon
Copy link
Owner

arkon commented Jun 9, 2017

Oh @lexcaraig you want either [mode]="'push'" or mode="push" because it's actually expecting the string 'push'.

I'll need to check on what you're saying though, @jraaaaanger .

@jraaaaanger
Copy link

@arkon Thanks, let me know if you need more info

@arkon
Copy link
Owner

arkon commented Jun 9, 2017

@jraaaaanger I made a separate issue for it: #93.

@arkon arkon modified the milestone: v6 Jun 26, 2017
@arkon arkon closed this as completed Jun 26, 2017
@arkon
Copy link
Owner

arkon commented Jun 26, 2017

Fixed in v6.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants