-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated project to kotlin 1.9.22 and build config to 5.3.5 #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this! There is no CI setup at the moment for PRs. Could you please make sure you have run all tests from the tests
folder? Just run the following.
cd tests
./gradlew build
@@ -55,3 +55,10 @@ allprojects { | |||
mavenCentral() | |||
} | |||
} | |||
|
|||
tasks.register("clean", Delete::class) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain wehy do we need this? I used to have a clean
task already.
No worries 😄, I did run the tests before submitting the PR. All good. |
Thanks for running the tests! Could you please also explain why do we need the |
This one cleans all the modules build folders. |
Thank you! The new version has been published and should become available soon. |
Glad I could help 😄 |
Updates: