Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated project to kotlin 1.9.22 and build config to 5.3.5 #3

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

demonar
Copy link
Contributor

@demonar demonar commented Mar 1, 2024

Updates:

  • Kotlin 1.9.22
  • buildconfig 5.3.5
  • java 11

@demonar demonar changed the title updated project to kotlin 1.9.22 and bui;d config to 5.3.5 updated project to kotlin 1.9.22 and build config to 5.3.5 Mar 1, 2024
Copy link
Owner

@arkivanov arkivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! There is no CI setup at the moment for PRs. Could you please make sure you have run all tests from the tests folder? Just run the following.

cd tests
./gradlew build

@@ -55,3 +55,10 @@ allprojects {
mavenCentral()
}
}

tasks.register("clean", Delete::class) {
Copy link
Owner

@arkivanov arkivanov Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain wehy do we need this? I used to have a clean task already.

@demonar
Copy link
Contributor Author

demonar commented Mar 1, 2024

No worries 😄, I did run the tests before submitting the PR. All good.

@arkivanov
Copy link
Owner

Thanks for running the tests! Could you please also explain why do we need the clean task? There used to be a clean task already defined.

@demonar
Copy link
Contributor Author

demonar commented Mar 1, 2024

This one cleans all the modules build folders.

@arkivanov arkivanov merged commit 69a089f into arkivanov:master Mar 1, 2024
@arkivanov
Copy link
Owner

Thank you! The new version has been published and should become available soon.

@demonar
Copy link
Contributor Author

demonar commented Mar 1, 2024

Glad I could help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants