Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Agriya Khetarpal <[email protected]>
  • Loading branch information
arjxn-py and agriyakhetarpal authored Dec 24, 2023
1 parent 430c86f commit 6aa6685
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/run_periodic_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,7 @@ jobs:
pyenv uninstall -f $( python --version )
test_install_odes:
needs: style
runs-on: macos-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
Expand All @@ -168,7 +167,13 @@ jobs:
- name: Check out PyBaMM repository
uses: actions/checkout@v4

- name: Install Linux system dependencies
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install gfortran gcc libopenblas-dev
- name: Install macOS system dependencies
if: matrix.os == 'macos-latest'
env:
# Homebrew environment variables
HOMEBREW_NO_INSTALL_CLEANUP: 1
Expand All @@ -187,10 +192,8 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Install PyBaMM dependencies
run: |
pip install --upgrade pip wheel setuptools nox
pip install -e .[all]
- name: Install PyBaMM
run: pip install -e .

- name: Test pybamm_install_odes on ${{ matrix.os }}
run: |
Expand Down
4 changes: 2 additions & 2 deletions docs/source/user_guide/installation/gnu-linux-mac.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
gnu-linux-mac & MacOS
=====================
GNU/Linux & macOS
=================

.. contents::

Expand Down

0 comments on commit 6aa6685

Please sign in to comment.