Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Fixes guard-jasmine #194

Closed
wants to merge 2 commits into from
Closed

Fixes guard-jasmine #194

wants to merge 2 commits into from

Conversation

antono
Copy link
Contributor

@antono antono commented Jan 11, 2012

Not only guard-jasmine but overall consistency.

Antono Vasiljev added 2 commits January 12, 2012 00:57
  Otherwise debug messages break popen users
  1.5 (development) (development) -> 1.5 (development)

  koz it's wrong and also breaks guard-jasmine version parser
@antono
Copy link
Contributor Author

antono commented Jan 11, 2012

related issue in guard-jasmine: guard/guard-jasmine#25

@@ -60,7 +60,7 @@

if (m_config.versionFlag()) {
m_terminated = true;
Terminal::instance()->cout(QString("%1 (development)").arg(PHANTOMJS_VERSION_STRING));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHANTOMJS_VERSION_STRING is already "1.5 (development)"

@ariya
Copy link
Owner

ariya commented Jan 12, 2012

@ariya
Copy link
Owner

ariya commented Jan 12, 2012

I merged the version fix. Thanks!

@ariya ariya closed this Jan 12, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants