fix conflict of RecyclerView's and ViewPager's lifecycles #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to RecyclerView lifecycle to fix bugwith delete button when PinLockView placed in ViewPager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I found one more little bug - I use your view in few places of my application and recently found that delete button don't work (visible bun not delete numbers) when PinLockView placed in fragment what placed in view pager. In this case - method of RecyclerViewAdapter onBindViewHolder called many times and all business logic (like OnClickListeners and others) placed in ViewHolder class stop to work. Definitely it's not good idea to place any business logic in ViewHolder class, it must be used only to store inflated views and no more.. Due to RecyclerView's lifecycle all business logic must be implemented in onBindViewHolder() for correct work. In my commit I moved all your business logic from constructors of ViewHolders to methods called from onBindViewHolder. Please check my changes and merge it. Thank you for your beautiful library.