-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurations for the addition of letters under buttons, as well as other relevant configurations. Merging does not affect previous builds #26
base: master
Are you sure you want to change the base?
Conversation
…nfigurations such as the colour of the letters. Added configuration to make the font bold.
Adding letters to buttons along with other UI tweaking configurations (backwards compatible)
Sorry for getting so late to you. The PR seems good at a glance. But there are few things that I need to decide if I want to include or not. Will get back to it very soon. |
Also wanted to understand the motivation behind adding letters under the numbers. Is it just for cosmetic purposes? Or does it serve some real use case? |
…w object was set to GONE then VISIBLE, and fixed the centering of the image in the button
Layout xml under v21 was updated but we had to update the layout xml too, since this has old logic of button
@aritraroy, This came from our UX designer. It is a standard practice as in phone number pad. Some people have hard time remembering PIN numbers. They can remember their PIN by translating the pin to some real word. Words are easier to remember. By the way, thanks for sharing this wonderful library. |
@aritraroy @tarslangil What version of the library do you plan on including these changes? |
@alexanderlin-okta Could you add your version of library to any gradle repository? As i understand this library is not maintained any more. |
Update to latest PinLockView
Update PinLockView to support enter button, input field, and inline delete button
Summary of changes
The goal of the changes is to add letters to the keypad under the numbers, as well as make some small changes, such as making the numbers bold and the color behavior of the back button (it used to turn the delete button white after clicking the delete button once, but now it will flash a predetermined color and then go back to the default color).
Changes to Implementation
Each button used to be a "Button" in Android XML but I changed it to a LinearLayout to accommodate both the text and numbers in the button. I also split the variables textColor and textSize into numberTextColor, lettersTextColor, numberTextSize, lettersTextSize, and made appropriate addition of functions/changes to the code to reflect this.
Each button's text used to be set to a number depending on its position. I leveraged this to set each position a specified text as well.
XML property changes
Deprecated (but still compatible) XML Configurations :
Added XML Configurations:
Snapshots of changes
Before
After