Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Done: Fix the UX of SearchBar & Bottom Nav Bar #156

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Done: Fix the UX of SearchBar & Bottom Nav Bar #156

merged 5 commits into from
Oct 18, 2023

Conversation

dharamveer-gupta
Copy link
Contributor

Resolved/Completed below enhancment :-

So, right now when we scroll the nav bar and search bar it sticks to their point but for the betterment of UX, we can do that when we scroll down the column both the nav & search bar gets hidden, and when the user scrolls up it both the nav & search bar should show up.

@dharamveer-gupta dharamveer-gupta mentioned this pull request Oct 16, 2023
Closed
@dharamveer-gupta dharamveer-gupta changed the title Done: Fix the UX of SearchBar & Bottom Nav Bar #148 Done: Fix the UX of SearchBar & Bottom Nav Bar Oct 16, 2023
@aritra-tech
Copy link
Owner

Can you please fix the ktlint checks @dharamveer-gupta.

@aritra-tech
Copy link
Owner

aritra-tech commented Oct 17, 2023 •
edited
Loading

Still there are 3 issues regarding ktlint @dharamveer-gupta

@dharamveer-gupta
Copy link
Contributor Author

Still there are 3 issues regarding ktlint @dharamveer-gupta

Sure, I will look into it

@dharamveer-gupta
Copy link
Contributor Author

I have resolved all the ktlint checks, @aritra-tech 👍

aritra-tech
aritra-tech approved these changes Oct 18, 2023
View reviewed changes
Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@aritra-tech aritra-tech merged commit 9795ef9 into aritra-tech:develop Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aritra-tech aritra-tech aritra-tech approved these changes

Assignees

@dharamveer-gupta dharamveer-gupta

Labels
features good first issue Good for newcomers hacktoberfest-accepted improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dharamveer-gupta @aritra-tech