Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized code by combining screens #104

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

bhoomigadhiya
Copy link
Contributor

Fixed #82
Optimized code by combining AddNote and EditNote Screen and their ViewModels.

@aritra-tech
Copy link
Owner

There is some merge conflict coming up can you please fix it up @bhoomi0104

@bhoomigadhiya
Copy link
Contributor Author

Resolve conflicts is disabled for me here.

@aritra-tech
Copy link
Owner

Use the command line to fix this.

@bhoomigadhiya
Copy link
Contributor Author

It's fixed now

@aritra-tech
Copy link
Owner

Yeah, @bhoomi0104 I have seen that it is being fixed need to check the code once right now busy with some work.
Will be checking soon.

Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aritra-tech aritra-tech self-assigned this Oct 2, 2023
@aritra-tech aritra-tech merged commit b38847b into aritra-tech:develop Oct 2, 2023
@bhoomigadhiya bhoomigadhiya deleted the optimize-code branch October 8, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants