-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matplotlib version issues and a circular import issue #686
Conversation
@Sichao25 Hi, Sichao, I believe a lot of failed tests were attributed to this issue. Can we find a better way to store the data? It seems that dropbox banned the non-browser downloading? One possible solution is to use some professional research data sharing platform like figshare (I've uploaded the data here https://figshare.com/articles/dataset/Dynamo_sample_datasets/25690782). This works
|
Sounds great. Thank you for detecting this issue. |
I've already uploaded all dropbox-based data to figshare and changed the urls in the codes in my own branch. Now trying to pass the github action unit tests. |
….15.0. Pass `density_norm='width'` for the same effect.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
=======================================
Coverage 43.59% 43.60%
=======================================
Files 161 161
Lines 28697 28724 +27
=======================================
+ Hits 12511 12524 +13
- Misses 16186 16200 +14 ☔ View full report in Codecov by Sentry. |
@chansigit excellent work! can we also support python 3.10 and 3.11, etc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a few comments
@@ -15,7 +15,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
python-version: [3.7, 3.8, 3.9] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add 3.9, 3.10, 3.11, 3.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.12 failed due to the removal of distutils
package https://stackoverflow.com/questions/77247893/modulenotfounderror-no-module-named-distutils-in-python-3-12
other versions on the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.10 and 3.11 also failed. we need more time to get it pass.
I noticed scanpy is asking a python version <3.10, we may remain in 3.9 temporarily.
https://github.com/scverse/scanpy/blob/db2118e8eb60bbf6287ce1413477480e16b2508b/pyproject.toml#L70
…s 3.1 by github action
@Sichao25 can you please reviewer it and finalize it? I will merge it to the main branch later |
init a branch for fixing
Deprecate `.A` attributes of sparse matrix in Sijie july24 fix
Deprecate more sparse matrix .A attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
group_corr
andgroup_score