Save velocity parameters to .varm instead .var #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 22.32% 22.75% +0.42%
==========================================
Files 158 160 +2
Lines 26356 26474 +118
==========================================
+ Hits 5885 6024 +139
+ Misses 20471 20450 -21
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Xiaojieqiu
reviewed
Oct 9, 2023
Comment on lines
-746
to
750
| if i in var_columns: | ||
| del adata.var[i] | ||
| if i in vel_params_df.columns: | ||
| del vel_params_df[i] | ||
|
|
There was a problem hiding this comment.
what adata.uns["vel_params_names"]?
There was a problem hiding this comment.
The adata.uns["vel_params_names"] will be updated later with update_vel_params(adata, params_df=vel_params_df).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a matrix called
vel_paramsin.varmto replace all velocity parameters in.var. Column names will be saved in.unsasvel_params_names. Cell-wise velocity will remain the same. Helper functions to read and update the parameters are created.