Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calc_ntr and make an enabler for cell_cycle_score #513

Merged
merged 2 commits into from
May 24, 2023

Conversation

Ukyeon
Copy link
Contributor

@Ukyeon Ukyeon commented May 19, 2023

  1. create a _calc_ntr function and call it within the Monocle recipe.
  2. Add a cell_cycle_score_enable parameter to allow users to enable the function.
  3. Make a minor fix by removing the line that raises a NotImplementedError in the cell_cycle_score function, which always causes an error with the default parameter 'show'.

@Sichao25
Copy link
Collaborator

Could you also add the parameter experiment_type to the Preprocessor.preprocess_adata() ? I think that could be helpful.

@Xiaojieqiu
Copy link
Collaborator

_calc_ntr and cell_cycle_score_enable can be called for different recipes right?

@Ukyeon
Copy link
Contributor Author

Ukyeon commented May 22, 2023

Calculation of calc_ntr and enabling cell_cycle_score can be utilized in different recipes, but they are currently not called within the existing code. Would you like to consider enabling them by default in the current operation?

@Xiaojieqiu Xiaojieqiu merged commit 5e7e5b8 into aristoteleo:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants