Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(devcontainer): Resolve issue with devcontainer and windows support #899

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix(devcontainer): Resolve issue with devcontainer and windows support #899

merged 1 commit into from
Apr 26, 2021

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Apr 26, 2021

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe): devcontainer

Proposed changes

  • Use configuration that support windows environment
  • Add support for codespace
  • Require to update a VScode setting on windows for docker driver
"remote.containers.workspaceMountConsistency": "delegated"

Known limitations

How to test

Use VScode devcontainer option.

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@carlbuchmann carlbuchmann merged commit fe0f3a8 into aristanetworks:devel Apr 26, 2021
@titom73 titom73 deleted the devcontainer/windows-support branch June 5, 2021 17:32
@titom73 titom73 restored the devcontainer/windows-support branch July 27, 2021 15:15
@titom73 titom73 deleted the devcontainer/windows-support branch October 1, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants