-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play one audio at a time #82
base: 2.0
Are you sure you want to change the base?
Play one audio at a time #82
Conversation
Just to comment on this - I'm building an app right now that is dependent on playing multiple audio files at the same time, so I wouldn't want this behavior as the default. The developer has complete control right now pause all other audio before playing a different track, and I personally think that's how it should remain. Cheers! |
When this commit is going to be merged in 2.0 branch? |
I think @alkrauss48 is right. The developer can control when/if to stop all other audio using the API. |
@alkrauss48 : How can one control the behavior? I tried but it seems it requires patch like the one provided by @chahalsukhveer . Are there any events on which I can register a function? |
@dhaval85 You are right, it looks like there is no global event to subscribe to on playback. I will submit a patch as soon as I can. |
@arielfaur : Thanks man. Let me know if I can help. I haven't seen the source code of this plugin yet but can review and add some more features. Let me know if you have any specific to implement this event stuff. We can support many other than only just play event. Besides, I think a configuration option would be good to control this behavior. What do you say? |
A configuration option for what purpose? |
@arielfaur configuration option to allow multiple songs play at the same time or not. |
Ok, I get it. I will look into that. |
@arielfaur Alright. Meantime I will see if I can submit a patch. Is 2.0 branch still active? |
No, we are on 3.0 now. |
Ahh okay. Is 3.0 compatible with Ionic 2.0? |
Not really, it is based on Ionic 3 and Angular 4. |
Looks like I have to consider switching to Ionic 3. Or probably whatever fixes you do in 3.0 branch. I will replicate them in 2.0. |
How to solve song overlap..when i click particular song,it play well after if i return back to other page then i click any other particular song,2 songs will play at a time @arielfaur |
It should pause already playing audio when user click play button for another audio.