fix start plugin method to be sync (elastic#55)

ari-aviran · Jan 13, 2022 · 17597c1 · 17597c1
1 parent c3755de
commit 17597c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/x-pack/plugins/cloud_security_posture/server/index_template/create_index_template.ts b/x-pack/plugins/cloud_security_posture/server/index_template/create_index_template.ts
@@ -56,6 +56,7 @@ export const createFindingsIndexTemplate = async (
       esClient,
       CSP_KUBEBEAT_INDEX_NAME,
       CSP_KUBEBEAT_INDEX_PATTERN,
+      // TODO: check why this cast is required
       findingsIndexMapping as Record<string, MappingProperty>
     );
   } catch (err) {

diff --git a/x-pack/plugins/cloud_security_posture/server/plugin.ts b/x-pack/plugins/cloud_security_posture/server/plugin.ts
@@ -31,14 +31,10 @@ export class CspPlugin implements Plugin<CspSetup, CspStart, CspPluginSetup, Csp
     return {};
   }
 
-  public async start(core: CoreStart) {
+  public start(core: CoreStart) {
     this.logger.debug('csp: Started');
-    try {
-      createFindingsIndexTemplate(core.elasticsearch.client.asInternalUser);
-    } catch (e) {
-      return {};
-    }
+    createFindingsIndexTemplate(core.elasticsearch.client.asInternalUser).catch(this.logger.error);
+    return {};
   }
-
   public stop() {}
 }