feat(opsgenie): Add support for setting priority in Opsgenie notification #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bofaalsarah
force-pushed
the
feature/opsgenie-priority
branch
2 times, most recently
from
6613522 to
8ddfc22
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 54.79% 54.99% +0.19%
==========================================
Files 35 35
Lines 3376 3386 +10
==========================================
+ Hits 1850 1862 +12
+ Misses 1254 1251 -3
- Partials 272 273 +1 ☔ View full report in Codecov by Sentry. |
bofaalsarah
force-pushed
the
feature/opsgenie-priority
branch
2 times, most recently
from
4e7d028 to
eedc5d3
Compare
…tions Signed-off-by: Bofa Alsarah <[email protected]>
bofaalsarah
force-pushed
the
feature/opsgenie-priority
branch
from
eedc5d3 to
595b339
Compare
|
Thank you @bofaalsarah , could you please add test for it ? |
Signed-off-by: Bofa Alsarah <[email protected]>
Done ✅ |
Signed-off-by: Bofa Alsarah <[email protected]>
pasha-codefresh
approved these changes
Feb 8, 2024
|
LGTM, thank you |
|
@bofaalsarah only one thing, could you please add some documentation about it? it can be dedicated PR |
|
Sure, I will create another PR for the documentation |
6 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting the priority field in Opsgenie notifications. If a priority is provided in the notification, it will be included in the alert creation request to Opsgenie. Additionally, the code now checks for missing description in Opsgenie notifications and returns an error if it's missing.