Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Health status customization in Argo for CRD resources #656

Closed
wants to merge 1 commit into from

Conversation

almoelda
Copy link

Health handling for CRDs suggested by @agaudreault
for argoproj/argo-cd#21119

@almoelda almoelda requested a review from a team as a code owner December 29, 2024 13:30
Copy link

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 75.60976% with 20 lines in your changes missing coverage. Please review.

Project coverage is 54.70%. Comparing base (8849c3f) to head (1f22c4c).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/health/health_customresourcedefinition.go 74.35% 19 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   54.26%   54.70%   +0.44%     
==========================================
  Files          64       65       +1     
  Lines        6164     6352     +188     
==========================================
+ Hits         3345     3475     +130     
- Misses       2549     2602      +53     
- Partials      270      275       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault
Copy link
Member

@almoelda Any particular reason to have this in the gitops-engine and not as a health customization lua script in argo?

For health extensions, i feel like Lua is much simpler and flexible if changes are required: https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-2-contribute-a-custom-health-check

@almoelda
Copy link
Author

almoelda commented Jan 7, 2025

@agaudreault You're right. I'll make the changes.

@almoelda almoelda closed this Jan 8, 2025
@almoelda almoelda deleted the master branch January 8, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants