Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor)!: Change argoexec base image to alpine. Closes #5720 #6006

Merged
merged 5 commits into from
Jun 5, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 25, 2021

Closes #5720

@alexec alexec changed the title feat(executor): Switch to alpine base image. Close #5720 feat(executor): Add argoexec-alpine image. Close #5720 May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #6006 (e3f9571) into master (3cfc96b) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6006      +/-   ##
==========================================
- Coverage   47.35%   47.30%   -0.05%     
==========================================
  Files         248      248              
  Lines       15663    15663              
==========================================
- Hits         7417     7410       -7     
- Misses       7316     7321       +5     
- Partials      930      932       +2     
Impacted Files Coverage Δ
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
cmd/argo/commands/get.go 56.45% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 70.39% <0.00%> (-0.28%) ⬇️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d077e4...e3f9571. Read the comment docs.

@alexec alexec changed the title feat(executor): Add argoexec-alpine image. Close #5720 feat(executor): Add argoexec-alpine image. Closes #5720 May 25, 2021
alexec added 4 commits May 25, 2021 11:12
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title feat(executor): Add argoexec-alpine image. Closes #5720 feat(executor): Change argoexec base image to alpine. Closes #5720 May 26, 2021
@alexec alexec marked this pull request as ready for review May 26, 2021 18:13
@alexec alexec changed the title feat(executor): Change argoexec base image to alpine. Closes #5720 feat(executor)!: Change argoexec base image to alpine. Closes #5720 May 26, 2021
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec added this to the v3.2 milestone May 31, 2021
@alexec
Copy link
Contributor Author

alexec commented Jun 1, 2021

Do not merge this PR. Let's hold it back for v3.2

@alexec alexec merged commit be63efe into master Jun 5, 2021
@alexec alexec deleted the dev-alpine branch June 5, 2021 20:09
@alexec alexec mentioned this pull request Jun 10, 2021
20 tasks
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
@alexec alexec mentioned this pull request Jun 21, 2021
16 tasks
@evax evax mentioned this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change argoexec to use alpine rather that debian
3 participants