Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove the need for pod annotations to be mounted as a volume !!POC!! #5950

Closed
wants to merge 4 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 19, 2021

See #5946

alexec added 2 commits May 19, 2021 09:16
Signed-off-by: Alex Collins <[email protected]>
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #5950 (72797b4) into master (3cfc96b) will increase coverage by 0.28%.
The diff coverage is 35.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5950      +/-   ##
==========================================
+ Coverage   47.35%   47.63%   +0.28%     
==========================================
  Files         248      248              
  Lines       15663    15485     -178     
==========================================
- Hits         7417     7377      -40     
+ Misses       7316     7187     -129     
+ Partials      930      921       -9     
Impacted Files Coverage Δ
cmd/argoexec/commands/root.go 1.49% <0.00%> (-0.05%) ⬇️
workflow/common/common.go 100.00% <ø> (ø)
workflow/controller/controller.go 19.42% <0.00%> (-0.41%) ⬇️
workflow/controller/pod_cleanup_key.go 20.00% <ø> (ø)
workflow/executor/executor.go 19.64% <0.00%> (+3.48%) ⬆️
workflow/executor/resource.go 26.66% <ø> (+1.37%) ⬆️
workflow/controller/exec_control.go 58.13% <37.50%> (+5.50%) ⬆️
workflow/controller/operator.go 70.33% <91.66%> (-0.34%) ⬇️
workflow/controller/dag.go 72.67% <100.00%> (ø)
workflow/controller/steps.go 72.30% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfc96b...72797b4. Read the comment docs.

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title chore: Refactor ARGO_INCLUDE_SCRIPT_OUTPUT refactor: Remove the need for pod annotatiso to be mounted as a volume May 19, 2021
@chazapis chazapis mentioned this pull request May 20, 2021
1 task
@alexec alexec changed the title refactor: Remove the need for pod annotatiso to be mounted as a volume refactor: Remove the need for pod annotations to be mounted as a volume !!POC!! May 20, 2021
@alexec alexec added this to the v3.3 milestone May 25, 2021
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec closed this May 26, 2021
@alexec alexec deleted the exec-ctl branch May 26, 2021 15:26
@alexec alexec modified the milestones: v3.3, v3.2 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant