-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(executor)!: Switch to alpine base image. Closes #5720 #5726
Conversation
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5726 +/- ##
==========================================
- Coverage 47.35% 46.81% -0.54%
==========================================
Files 248 244 -4
Lines 15655 15220 -435
==========================================
- Hits 7413 7126 -287
+ Misses 7312 7188 -124
+ Partials 930 906 -24
Continue to review full report at Codecov.
|
Signed-off-by: Alex Collins <[email protected]>
@@ -4,7 +4,6 @@ ARG DOCKER_CHANNEL=stable | |||
ARG DOCKER_VERSION=18.09.1 | |||
# NOTE: kubectl version should be one minor version less than https://storage.googleapis.com/kubernetes-release/release/stable.txt | |||
ARG KUBECTL_VERSION=1.19.6 | |||
ARG JQ_VERSION=1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this would break backwards compatibility for users who are using jq<=1.6
?
edit: nvm, looks like 1.6 is the latest release and there hasn’t been any new release for three years.
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
The primary benefit is reducing the attack surface and therefore reducing the number of vulnerabilities:
Secondary benefits: