Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor)!: Switch to alpine base image. Closes #5720 #5726

Closed
wants to merge 5 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 20, 2021

The primary benefit is reducing the attack surface and therefore reducing the number of vulnerabilities:

Testing argoproj/argoexec:latest...

Organization:      argoproj
Package manager:   apk
Project name:      docker-image|argoproj/argoexec
Docker image:      argoproj/argoexec:latest
Platform:          linux/amd64
Licenses:          enabled

✓ Tested 32 dependencies for known issues, no vulnerable paths found.

Secondary benefits:

  • Reduced build time.
  • Reduced image size -> reduced start-up time. 429M -> 284.1M (ish)

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #5726 (cd9c8ad) into master (d7c5cf6) will decrease coverage by 0.53%.
The diff coverage is n/a.

❗ Current head cd9c8ad differs from pull request most recent head 19692a2. Consider uploading reports for the commit 19692a2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5726      +/-   ##
==========================================
- Coverage   47.35%   46.81%   -0.54%     
==========================================
  Files         248      244       -4     
  Lines       15655    15220     -435     
==========================================
- Hits         7413     7126     -287     
+ Misses       7312     7188     -124     
+ Partials      930      906      -24     
Impacted Files Coverage Δ
cmd/argo/commands/stop.go 0.00% <0.00%> (-55.39%) ⬇️
cmd/argo/commands/resubmit.go 0.00% <0.00%> (-48.06%) ⬇️
cmd/argo/commands/retry.go 0.00% <0.00%> (-43.04%) ⬇️
cmd/argo/commands/list.go 46.42% <0.00%> (-2.39%) ⬇️
server/workflow/workflow_server.go 40.45% <0.00%> (-2.28%) ⬇️
workflow/executor/resource.go 22.80% <0.00%> (-2.20%) ⬇️
server/artifacts/artifact_server.go 57.27% <0.00%> (-2.05%) ⬇️
workflow/controller/steps.go 70.50% <0.00%> (-1.80%) ⬇️
workflow/controller/exec_control.go 51.08% <0.00%> (-1.55%) ⬇️
pkg/apis/workflow/v1alpha1/workflow_types.go 46.04% <0.00%> (-0.98%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7517cf...19692a2. Read the comment docs.

@alexec alexec linked an issue Apr 20, 2021 that may be closed by this pull request
@alexec alexec changed the title feat(executor): Switch to alpine base image. Close #5720 feat(executor): Switch to alpine base image. Closes #5720 Apr 20, 2021
Signed-off-by: Alex Collins <[email protected]>
@@ -4,7 +4,6 @@ ARG DOCKER_CHANNEL=stable
ARG DOCKER_VERSION=18.09.1
# NOTE: kubectl version should be one minor version less than https://storage.googleapis.com/kubernetes-release/release/stable.txt
ARG KUBECTL_VERSION=1.19.6
ARG JQ_VERSION=1.6
Copy link
Member

@terrytangyuan terrytangyuan Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this would break backwards compatibility for users who are using jq<=1.6?

edit: nvm, looks like 1.6 is the latest release and there hasn’t been any new release for three years.

@alexec alexec changed the title feat(executor): Switch to alpine base image. Closes #5720 feat(executor)!: Switch to alpine base image. Closes #5720 Apr 27, 2021
@alexec alexec added this to the v3.2 milestone Apr 27, 2021
alexec added 2 commits May 9, 2021 12:31
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec closed this May 25, 2021
@alexec alexec deleted the alpine branch May 25, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change argoexec to use alpine rather that debian
2 participants