feat: Template defaults #5410
Merged
feat: Template defaults #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5410 +/- ##
==========================================
+ Coverage 16.28% 16.48% +0.20%
==========================================
Files 243 243
Lines 43665 43769 +104
==========================================
+ Hits 7109 7214 +105
+ Misses 35584 35573 -11
- Partials 972 982 +10
Continue to review full report at Codecov.
|
sarabala1979
commented
Mar 17, 2021
| @@ -489,7 +492,7 @@ func (wfs *WorkflowSpec) HasPodSpecPatch() bool { | |||
| // Template is a reusable and composable unit of execution in a workflow | |||
| type Template struct { | |||
| // Name is the name of the template | |||
| Name string `json:"name" protobuf:"bytes,1,opt,name=name"` | |||
| Name string `json:"name,omitempty" protobuf:"bytes,1,opt,name=name"` | |||
There was a problem hiding this comment.
This field is validated by CLI, UI, and controller. But the only restriction when the user using swagger.json or SDK they need to set a dummy value on this.
|
I will add more unit test to cover the code coverage |
|
assigning @jessesuen for proto approval |
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
alexec
reviewed
Mar 17, 2021
Signed-off-by: Saravanan Balasubramanian <[email protected]>
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
closes #3201