-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix path to openapi-gen binary #5089
Conversation
Makefile
Outdated
@@ -502,7 +502,7 @@ clean: | |||
|
|||
pkg/apis/workflow/v1alpha1/openapi_generated.go: $(GOPATH)/bin/openapi-gen $(TYPES) | |||
[ -e v3 ] || ln -s . v3 | |||
openapi-gen \ | |||
${GOPATH}/bin/openapi-gen \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(GOPATH)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used curly brances to be consistent with other similar places in Makefile, e.g. ${GOPATH}/bin/go-to-protobuf
. Would you like me to change all of them to ()
in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just replaced all the {}
by ()
for consistency.
Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
Currently the openapi-gen binary is installed to
$GOPATH/bin
but we are calling it with other path. This will introduce errors when older versions ofopenapi-gen
has installed (for use in other projects) and confuses the path.Signed-off-by: terrytangyuan [email protected]
Checklist: