Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove deprecated fields #5035

Merged
merged 8 commits into from
Feb 10, 2021
Merged

chore!: Remove deprecated fields #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f85dd4
chore: Remove deprecated fields
simster7 Feb 5, 2021
f452db3
prog
simster7 Feb 5, 2021
0841af0
Merge branch 'master' into depr
simster7 Feb 8, 2021
954106e
prog
simster7 Feb 8, 2021
52e1ff6
WIP
simster7 Feb 8, 2021
09a28f4
Merge branch 'master' into depr
simster7 Feb 10, 2021
5e7c333
fix tests
simster7 Feb 10, 2021
b2be249
tests + lint
simster7 Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions api/jsonschema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3862,10 +3862,6 @@
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "Time at which this node started"
},
"storedTemplateID": {
"description": "StoredTemplateID is the ID of stored template. DEPRECATED: This value is not used anymore.",
"type": "string"
},
"synchronizationStatus": {
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.NodeSynchronizationStatus",
"description": "SynchronizationStatus is the synchronization status of the node"
Expand All @@ -3885,10 +3881,6 @@
"type": {
"description": "Type indicates type of node",
"type": "string"
},
"workflowTemplateName": {
"description": "WorkflowTemplateName is the WorkflowTemplate resource name on which the resolved template of this node is retrieved. DEPRECATED: This value is not used anymore.",
"type": "string"
}
},
"required": [
Expand Down Expand Up @@ -4561,10 +4553,6 @@
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactLocation",
"description": "Location in which all files related to the step will be stored (logs, artifacts, etc...). Can be overridden by individual items in Outputs. If omitted, will use the default artifact repository location configured in the controller, appended with the \u003cworkflowname\u003e/\u003cnodename\u003e in the key."
},
"arguments": {
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.Arguments",
"description": "Arguments hold arguments to the template. DEPRECATED: This field is not used."
},
"automountServiceAccountToken": {
"description": "AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.",
"type": "boolean"
Expand Down Expand Up @@ -4698,14 +4686,6 @@
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.Synchronization",
"description": "Synchronization holds synchronization lock configuration for this template"
},
"template": {
"description": "Template is the name of the template which is used as the base of this template. DEPRECATED: This field is not used.",
"type": "string"
},
"templateRef": {
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.TemplateRef",
"description": "TemplateRef is the reference to the template resource which is used as the base of this template. DEPRECATED: This field is not used."
},
"timeout": {
"description": "Timout allows to set the total node execution timeout duration counting from the node's start time. This duration also includes time in which the node spends in Pending state. This duration may not be applied to Step or DAG templates.",
"type": "string"
Expand Down Expand Up @@ -4745,10 +4725,6 @@
"description": "Name is the resource name of the template.",
"type": "string"
},
"runtimeResolution": {
"description": "RuntimeResolution skips validation at creation time. By enabling this option, you can create the referred workflow template before the actual runtime. DEPRECATED: This value is not used anymore and is ignored",
"type": "boolean"
},
"template": {
"description": "Template is the name of referred template in the resource.",
"type": "string"
Expand Down Expand Up @@ -5366,10 +5342,6 @@
"x-kubernetes-patch-merge-key": "key",
"x-kubernetes-patch-strategy": "merge"
},
"ttlSecondsAfterFinished": {
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution (Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be deleted after ttlSecondsAfterFinished expires. If this field is unset, ttlSecondsAfterFinished will not expire. If this field is set to zero, ttlSecondsAfterFinished expires immediately after the Workflow finishes. DEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead.",
"type": "integer"
},
"ttlStrategy": {
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.TTLStrategy",
"description": "TTLStrategy limits the lifetime of a Workflow that has finished execution depending on if it Succeeded or Failed. If this struct is set, once the Workflow finishes, it will be deleted after the time to live expires. If this field is unset, the controller config map will hold the default values."
Expand Down Expand Up @@ -5834,10 +5806,6 @@
"x-kubernetes-patch-merge-key": "key",
"x-kubernetes-patch-strategy": "merge"
},
"ttlSecondsAfterFinished": {
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution (Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be deleted after ttlSecondsAfterFinished expires. If this field is unset, ttlSecondsAfterFinished will not expire. If this field is set to zero, ttlSecondsAfterFinished expires immediately after the Workflow finishes. DEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead.",
"type": "integer"
},
"ttlStrategy": {
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.TTLStrategy",
"description": "TTLStrategy limits the lifetime of a Workflow that has finished execution depending on if it Succeeded or Failed. If this struct is set, once the Workflow finishes, it will be deleted after the time to live expires. If this field is unset, the controller config map will hold the default values."
Expand Down
32 changes: 0 additions & 32 deletions api/openapi-spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7282,10 +7282,6 @@
"description": "Time at which this node started",
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Time"
},
"storedTemplateID": {
"description": "StoredTemplateID is the ID of stored template. DEPRECATED: This value is not used anymore.",
"type": "string"
},
"synchronizationStatus": {
"description": "SynchronizationStatus is the synchronization status of the node",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.NodeSynchronizationStatus"
Expand All @@ -7305,10 +7301,6 @@
"type": {
"description": "Type indicates type of node",
"type": "string"
},
"workflowTemplateName": {
"description": "WorkflowTemplateName is the WorkflowTemplate resource name on which the resolved template of this node is retrieved. DEPRECATED: This value is not used anymore.",
"type": "string"
}
}
},
Expand Down Expand Up @@ -7979,10 +7971,6 @@
"description": "Location in which all files related to the step will be stored (logs, artifacts, etc...). Can be overridden by individual items in Outputs. If omitted, will use the default artifact repository location configured in the controller, appended with the \u003cworkflowname\u003e/\u003cnodename\u003e in the key.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactLocation"
},
"arguments": {
"description": "Arguments hold arguments to the template. DEPRECATED: This field is not used.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.Arguments"
},
"automountServiceAccountToken": {
"description": "AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.",
"type": "boolean"
Expand Down Expand Up @@ -8116,14 +8104,6 @@
"description": "Synchronization holds synchronization lock configuration for this template",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.Synchronization"
},
"template": {
"description": "Template is the name of the template which is used as the base of this template. DEPRECATED: This field is not used.",
"type": "string"
},
"templateRef": {
"description": "TemplateRef is the reference to the template resource which is used as the base of this template. DEPRECATED: This field is not used.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.TemplateRef"
},
"timeout": {
"description": "Timout allows to set the total node execution timeout duration counting from the node's start time. This duration also includes time in which the node spends in Pending state. This duration may not be applied to Step or DAG templates.",
"type": "string"
Expand Down Expand Up @@ -8160,10 +8140,6 @@
"description": "Name is the resource name of the template.",
"type": "string"
},
"runtimeResolution": {
"description": "RuntimeResolution skips validation at creation time. By enabling this option, you can create the referred workflow template before the actual runtime. DEPRECATED: This value is not used anymore and is ignored",
"type": "boolean"
},
"template": {
"description": "Template is the name of referred template in the resource.",
"type": "string"
Expand Down Expand Up @@ -8777,10 +8753,6 @@
"x-kubernetes-patch-merge-key": "key",
"x-kubernetes-patch-strategy": "merge"
},
"ttlSecondsAfterFinished": {
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution (Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be deleted after ttlSecondsAfterFinished expires. If this field is unset, ttlSecondsAfterFinished will not expire. If this field is set to zero, ttlSecondsAfterFinished expires immediately after the Workflow finishes. DEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead.",
"type": "integer"
},
"ttlStrategy": {
"description": "TTLStrategy limits the lifetime of a Workflow that has finished execution depending on if it Succeeded or Failed. If this struct is set, once the Workflow finishes, it will be deleted after the time to live expires. If this field is unset, the controller config map will hold the default values.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.TTLStrategy"
Expand Down Expand Up @@ -9243,10 +9215,6 @@
"x-kubernetes-patch-merge-key": "key",
"x-kubernetes-patch-strategy": "merge"
},
"ttlSecondsAfterFinished": {
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution (Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be deleted after ttlSecondsAfterFinished expires. If this field is unset, ttlSecondsAfterFinished will not expire. If this field is set to zero, ttlSecondsAfterFinished expires immediately after the Workflow finishes. DEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead.",
"type": "integer"
},
"ttlStrategy": {
"description": "TTLStrategy limits the lifetime of a Workflow that has finished execution depending on if it Succeeded or Failed. If this struct is set, once the Workflow finishes, it will be deleted after the time to live expires. If this field is unset, the controller config map will hold the default values.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.TTLStrategy"
Expand Down
Loading