feat(executor): Add user agent to workflow executor #5014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terrytangyuan <[email protected]>
alexec
reviewed
Feb 3, 2021
cmd/argoexec/commands/root.go
Outdated
| @@ -72,6 +74,7 @@ func NewRootCommand() *cobra.Command { | |||
| func initExecutor() *executor.WorkflowExecutor { | |||
| log.WithField("version", argo.GetVersion().Version).Info("Starting Workflow Executor") | |||
| config, err := clientConfig.ClientConfig() | |||
| config = restclient.AddUserAgent(config, fmt.Sprintf("argo-workflow-%s-executor", os.Getenv(common.EnvVarContainerRuntimeExecutor))) | |||
There was a problem hiding this comment.
user agent should probably be something like
User-Agent: <product> / <product-version> <comment>
E.g.
argo-workflows/v3.0.0 executor/docker
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent
There was a problem hiding this comment.
Thanks! Just updated the UA to follow the convention.
Signed-off-by: terrytangyuan <[email protected]>
alexec
reviewed
Feb 4, 2021
| config, err := clientConfig.ClientConfig() | ||
| config = restclient.AddUserAgent(config, fmt.Sprintf("argo-workflow-%s-executor", os.Getenv(common.EnvVarContainerRuntimeExecutor))) | ||
| executorType := os.Getenv(common.EnvVarContainerRuntimeExecutor) | ||
| config = restclient.AddUserAgent(config, fmt.Sprintf("argo-workflows/%s executor/%s", version.Version, executorType)) |
There was a problem hiding this comment.
@jessesuen thoughts on this User-Agent?
|
Awaiting feedback from @jessesuen. |
jessesuen
approved these changes
Feb 10, 2021
|
Seems like it would be beneficial without any risk. |
alexec
changed the title
alexec
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many different applications calling apiserver and setting the user agent would allow us to distinguish the API calls among those applications for further traffic control/monitoring. This would also prepare us to try different executors in #4998 and monitor their relevant traffic.
Signed-off-by: terrytangyuan [email protected]
Checklist: