Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AutomountServiceAccountToken #1480

Merged
merged 15 commits into from
Aug 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,16 @@
}
}
},
"io.argoproj.workflow.v1alpha1.ExecutorConfig": {
"description": "ExecutorConfig holds configurations of an executor container.",
"type": "object",
"properties": {
"serviceAccountName": {
"description": "ServiceAccountName specifies the service account name of the executor container.",
"type": "string"
}
}
},
"io.argoproj.workflow.v1alpha1.GitArtifact": {
"description": "GitArtifact is the location of an git artifact",
"type": "object",
Expand Down Expand Up @@ -891,6 +901,10 @@
"description": "Arguments hold arguments to the template.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.Arguments"
},
"automountServiceAccountToken": {
"description": "AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.",
"type": "boolean"
},
"container": {
"description": "Container is the main container image to run in the pod",
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
Expand All @@ -903,6 +917,10 @@
"description": "DAG template subtype which runs a DAG",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.DAGTemplate"
},
"executor": {
"description": "Executor holds configurations of the executor container.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ExecutorConfig"
},
"hostAliases": {
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod spec",
"type": "array",
Expand Down Expand Up @@ -1274,6 +1292,10 @@
"description": "ArtifactRepositoryRef specifies the configMap name and key containing the artifact repository config.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactRepositoryRef"
},
"automountServiceAccountToken": {
"description": "AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.",
"type": "boolean"
},
"dnsConfig": {
"description": "PodDNSConfig defines the DNS parameters of a pod in addition to those generated from DNSPolicy.",
"$ref": "#/definitions/io.k8s.api.core.v1.PodDNSConfig"
Expand All @@ -1286,6 +1308,10 @@
"description": "Entrypoint is a template reference to the starting point of the workflow",
"type": "string"
},
"executor": {
"description": "Executor holds configurations of executor containers of the workflow.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ExecutorConfig"
},
"hostAliases": {
"description": "HostAliases is an optional list of hosts and IPs that will be injected into the pod spec",
"type": "array",
Expand Down
8 changes: 4 additions & 4 deletions manifests/base/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

bases:
- crds
- workflow-controller
- argo-ui

images:
- name: argoproj/argoui
Expand All @@ -13,3 +9,7 @@ images:
- name: argoproj/workflow-controller
newName: argoproj/workflow-controller
newTag: latest
resources:
- crds
- workflow-controller
- argo-ui
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,10 @@ rules:
- get
- list
- watch
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- get
- list
22 changes: 18 additions & 4 deletions manifests/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ spec:
apiVersion: v1
kind: ServiceAccount
metadata:
name: argo-ui
name: argo
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: argo
name: argo-ui
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Expand Down Expand Up @@ -142,15 +142,29 @@ rules:
resources:
- workflows
- workflows/finalizers
- workflowtemplates
- workflowtemplates/finalizers
verbs:
- get
- list
- watch
- update
- patch
- delete
- apiGroups:
- argoproj.io
resources:
- workflowtemplates
- workflowtemplates/finalizers
verbs:
- get
- list
- watch
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- get
- list
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Expand Down
11 changes: 9 additions & 2 deletions manifests/namespace-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ spec:
apiVersion: v1
kind: ServiceAccount
metadata:
name: argo-ui
name: argo
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: argo
name: argo-ui
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand Down Expand Up @@ -82,6 +82,13 @@ rules:
- update
- patch
- delete
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- get
- list
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,10 @@ rules:
- update
- patch
- delete
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- get
- list
51 changes: 49 additions & 2 deletions pkg/apis/workflow/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions pkg/apis/workflow/v1alpha1/workflow_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ type WorkflowSpec struct {
// ServiceAccountName is the name of the ServiceAccount to run all pods of the workflow as.
ServiceAccountName string `json:"serviceAccountName,omitempty"`

// AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods.
// ServiceAccountName of ExecutorConfig must be specified if this value is false.
AutomountServiceAccountToken *bool `json:"automountServiceAccountToken,omitempty"`

// Executor holds configurations of executor containers of the workflow.
Executor *ExecutorConfig `json:"executor,omitempty"`

// Volumes is a list of volumes that can be mounted by containers in a workflow.
Volumes []apiv1.Volume `json:"volumes,omitempty"`

Expand Down Expand Up @@ -306,6 +313,13 @@ type Template struct {
// ServiceAccountName to apply to workflow pods
ServiceAccountName string `json:"serviceAccountName,omitempty"`

// AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods.
// ServiceAccountName of ExecutorConfig must be specified if this value is false.
AutomountServiceAccountToken *bool `json:"automountServiceAccountToken,omitempty"`

// Executor holds configurations of the executor container.
Executor *ExecutorConfig `json:"executor,omitempty"`

// HostAliases is an optional list of hosts and IPs that will be injected into the pod spec
HostAliases []apiv1.HostAlias `json:"hostAliases,omitempty"`

Expand Down Expand Up @@ -947,6 +961,12 @@ func (h *HTTPArtifact) HasLocation() bool {
return h != nil && h.URL != ""
}

// ExecutorConfig holds configurations of an executor container.
type ExecutorConfig struct {
// ServiceAccountName specifies the service account name of the executor container.
ServiceAccountName string `json:"serviceAccountName,omitempty"`
}

// ScriptTemplate is a template subtype to enable scripting through code steps
type ScriptTemplate struct {
apiv1.Container `json:",inline"`
Expand Down
Loading