docs: clarify Skipped and Omitted in enhanced depends
#13087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverdain
changed the title
Signed-off-by: Oliver Dain <[email protected]>
oliverdain
force-pushed
the
oliver/enhanced-docs
branch
from
96f09a8 to
d04027e
Compare
Signed-off-by: Oliver Dain <[email protected]>
Signed-off-by: Oliver Dain <[email protected]>
agilgur5
changed the title
Skipped and Omitted in enhanced depends
Joibel
approved these changes
May 28, 2024
|
Thanks @oliverdain for your contribution. |
agilgur5
reviewed
May 29, 2024
There was a problem hiding this comment.
I left some grammatical corrections below, but this can also be improved and simplified, per our style guide.
I think this whole page could use a copy-edit though (like some of my previous docs changes), so I can make those changes as part of a larger rewrite. EDIT: See #13110
agilgur5
pushed a commit
that referenced
this pull request
Jun 2, 2024
Signed-off-by: Oliver Dain <[email protected]> (cherry picked from commit f492ea3)
agilgur5
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Oliver Dain <[email protected]> (cherry picked from commit f492ea3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: update the enhanced depends documentation
It wasn't clear to me what
OmittedandSkippedmeant. I'm still not sure I have this correct but I'm going off advice I got in the Argo Slack.