-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: setBucketLifecycleRule error in OSS Artifact Driver. Fixes #12925 #12926
fix: setBucketLifecycleRule error in OSS Artifact Driver. Fixes #12925 #12926
Conversation
4345651
to
8cf5884
Compare
…SS Artifact Driver. Signed-off-by: AlbeeSo <[email protected]>
8cf5884
to
7ec9daa
Compare
workflow/artifacts/oss/oss.go
Outdated
NonVersionTransitions: []oss.LifecycleVersionTransition{versionTransition}, | ||
|
||
rule := oss.LifecycleRule{ | ||
ID: "argo-workflows-rule", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this ID need to correspond to artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSS ArtifactDriver could only receive the name of key and setting of OSSBucket, so I used sha256(key) as ID which could avoid exceeding length limit.
Signed-off-by: AlbeeSo <[email protected]>
f8689f1
to
a6fc0a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#12926) Signed-off-by: AlbeeSo <[email protected]> (cherry picked from commit a4fc318)
Fixes #12925
Motivation
OSS does not support to set different rules at a time for a same prefix and that's why I received a 400 error. And more details added in related issue.
Modifications
LifecycleRule modified to:
Verification
Please test with workflow