build(manifests): quick-start should use cluster-install
#12557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prior to bedd47f, the quick start docs used the `install.yaml` instead of the `quick-start-minimal.yaml` manifests - `install.yaml` is [a cluster install](https://github.com/argoproj/argo-workflows/blob/df79ce47c467823092a3819495418242984ff13e/Makefile#L419), so `quick-start-minimal.yaml` should also use a cluster install - without the `cluster-install`, you have to manually navigate to the `argo` namespace in the UI - and you see an error until you do so, which is confusing to new users (see also this [Slack thread](https://cloud-native.slack.com/archives/C01QW9QSSSK/p1705544478244329?thread_ts=1705530455.489149&cid=C01QW9QSSSK)) - the quick start manifests already have fairly broad permissions and several warnings about not using them in prod, so this usage would be consistent - with this usage, we can remove some docs and overlay code from the quick start - `--namespaced` should not be used anymore now that we use a cluster install - patching the Argo Server is no longer necessary as the quick-start overlay already contains `--auth-mode=server` Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
area/docs
- `changed-files` should check for these as well, since they are part of `make codegen`, just not the Swagger portion Signed-off-by: Anton Gilgur <[email protected]>
juliev0
approved these changes
Feb 17, 2024
agilgur5
added a commit
that referenced
this pull request
May 11, 2024
Signed-off-by: Anton Gilgur <[email protected]> (cherry picked from commit 8ebf433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups to #12445 and this related Slack thread
Motivation
prior to docs: change quick-start guide to use quick-start install. Fixes #12391 #12445, the quick start docs used the
install.yamlinstead of thequick-start-minimal.yamlmanifestsinstall.yamlis a cluster install, soquick-start-minimal.yamlshould also use a cluster install to match the past behaviorwithout the
cluster-install, you have to manually navigate to theargonamespace in the UIthe quick start manifests already have fairly broad permissions (in order to get started quickly) and several warnings about not using them in prod, so this usage would be consistent
Modifications
use
cluster-installinstead ofnamespace-installin the quick start manifests--namespacedshould not be used anymore now that we use a cluster install--auth-mode=servercodegen
manifests/quick-start*.yamladd
manifests/**tocodegenon CI'schanged-filescheckVerification