Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add message when parse of private key fails due to existing sso secret. Fixes #10420 #10421

Merged

Conversation

yktakaha4
Copy link
Contributor

Fixes #10420

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@yktakaha4
Copy link
Contributor Author

In my environment, make pre-commit -B was failing due to a missing newline at the end of the following file.
(If necessary, I would like to create another PR after further investigation)

ref: golangci/golangci-lint#1726

$ git diff util/grpc/interceptor.go
diff --git a/util/grpc/interceptor.go b/util/grpc/interceptor.go
index 0ca0a3c3..552b0723 100644
--- a/util/grpc/interceptor.go
+++ b/util/grpc/interceptor.go
@@ -94,4 +94,4 @@ func getClientIP(ctx context.Context) string {
        address := p.Addr.String()
        ip := strings.Split(address, ":")[0]
        return ip
-}
\ No newline at end of file
+}

@yktakaha4 yktakaha4 force-pushed the fix/sso-secret-already-exists branch from b9a5a0d to 780ff4b Compare January 29, 2023 17:09
@yktakaha4 yktakaha4 force-pushed the fix/sso-secret-already-exists branch from 780ff4b to 2524674 Compare January 29, 2023 22:37
@yktakaha4 yktakaha4 marked this pull request as ready for review January 29, 2023 23:02
@yktakaha4 yktakaha4 changed the title fix: add message when secret creation fails from existing sso. Fixes #10420 fix: add message when parse of private key fails due to existing sso secret. Fixes #10420 Jan 29, 2023
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarabala1979 sarabala1979 merged commit 1d87b45 into argoproj:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to parse private key: asn1: syntax error: sequence truncated
3 participants