Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix deadlock when controller is restarted. Fixes #8684 #10009

Closed
wants to merge 15 commits into from

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Nov 10, 2022

Fixes #8684

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@isubasinghe isubasinghe changed the title WIP [WIP] Fix deadlock when controller is restarted. Fixes #8684 Nov 10, 2022
@isubasinghe isubasinghe force-pushed the fix-deadlock branch 4 times, most recently from 2492ee2 to b41f5bc Compare November 20, 2022 04:53
@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Dec 31, 2022
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this Jan 8, 2023
@isubasinghe isubasinghe reopened this Jan 10, 2023
@stale stale bot removed the problem/stale This has not had a response in some time label Jan 10, 2023
@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 25, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this May 21, 2023
@isubasinghe
Copy link
Member Author

not stale

@isubasinghe isubasinghe reopened this May 25, 2023
@stale stale bot removed the problem/stale This has not had a response in some time label May 25, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Jun 18, 2023
@stale
Copy link

stale bot commented Aug 13, 2023

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this Aug 13, 2023
@agilgur5 agilgur5 added area/controller Controller issues, panics area/mutex-semaphore labels Sep 11, 2023
@agilgur5
Copy link

agilgur5 commented Sep 4, 2024

Looks like this has been superseded by #13553

@agilgur5 agilgur5 added solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) and removed problem/stale This has not had a response in some time labels Sep 20, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/controller Controller issues, panics area/mutex-semaphore solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow deadlocks on mutex in steps template if controller is restarted
2 participants