Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech debug: migrate tooling to take advantage of Go 1.16 #6892

Closed
3 tasks done
Tracked by #6890
alexec opened this issue Oct 7, 2021 · 2 comments · Fixed by #6893
Closed
3 tasks done
Tracked by #6890

tech debug: migrate tooling to take advantage of Go 1.16 #6892

alexec opened this issue Oct 7, 2021 · 2 comments · Fixed by #6893
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request

Comments

@alexec
Copy link
Contributor

alexec commented Oct 7, 2021 •
edited
Loading

A lot of our build is designed to deal with shortcomings of Go 1.15 which are fixed in Go 1.16:

  • Install tools using go install instead of go get to pin the versions:
go get golang.org/x/tools/cmd/goimports
# becomes 
go install golang.org/x/tools/cmd/[email protected]
  • Get rid of tools.go.
  • Replace staticfiles with Golang 1.16 built-in feature.

This is the first step to Dockerize tooling as per #6519 and #6618, #6890 .

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@alexec alexec added the type/feature Feature request label Oct 7, 2021
@alexec alexec mentioned this issue Oct 7, 2021
Closed
2 tasks
@alexec
Copy link
Contributor Author

alexec commented Oct 8, 2021

Replace staticfiles with Golang 1.16 built-in feature.

I think we should leave this. It uses the same patterns as plenty of other tools we use.

@alexec alexec linked a pull request Oct 8, 2021 that will close this issue
build: simplify using Golang 1.16 #6893
Merged
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Oct 20, 2023
@agilgur5
Copy link

agilgur5 commented Oct 20, 2023 •
edited
Loading

Replace staticfiles with Golang 1.16 built-in feature.

I think we should leave this. It uses the same patterns as plenty of other tools we use.

For posterity, we are moving off of staticfiles to the embed built-in per #11654 (+ #11052). CD uses it nowadays and staticfiles is also archived nowadays (see the issue for more details).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: simplify using Golang 1.16 argoproj/argo-workflows
2 participants
@alexec @agilgur5