Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify execution control #5356

Closed
alexec opened this issue Mar 10, 2021 · 1 comment
Closed

simplify execution control #5356

alexec opened this issue Mar 10, 2021 · 1 comment

Comments

@alexec
Copy link
Contributor

alexec commented Mar 10, 2021 •
edited
Loading

I think the system could be simplified greatly. Execution control has two purposes:

  • Set the includeScriptOutput flag. This is immutable and we can use the ARGO_INCLUDE_SCRIPT_OUTPUT flag.
alexec added a commit to alexec/argo-workflows that referenced this issue Mar 10, 2021
@alexec
feat(controller): Controller, rather than executor, terminates contai…
d585655 
…ners. Closes argoproj#5356

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec removed the type/feature Feature request label Apr 16, 2021
@alexec
Copy link
Contributor Author

alexec commented Apr 16, 2021

Fixed in feat(controller) Emissary executor. (#4925) I think.

@alexec alexec closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexec