fix: debug e2e ci failures

Signed-off-by: Dana Pieluszczak <[email protected]>
argoproj · Nov 30, 2022 · ad6b2fa · ad6b2fa
1 parent ddca9cb
commit ad6b2fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/test/e2e/functional/tty.yaml b/test/e2e/functional/tty.yaml
@@ -21,7 +21,7 @@ spec:
         source: |
           if [[ ! -t 0 ]]; then
             echo "I should be in a terminal but I'm not"
-            exit 1
+            exit 4
           fi
 
     - name: tty-false
@@ -31,5 +31,5 @@ spec:
         source: |
           if [[ -t 0 ]]; then
             echo "I should not be in a terminal but I am"
-            exit 1
+            exit 4
           fi
diff --git a/workflow/executor/os-specific/command.go b/workflow/executor/os-specific/command.go
@@ -5,6 +5,7 @@ import (
 	"os"
 	"os/exec"
 
+	log "github.com/sirupsen/logrus"
 	"golang.org/x/term"
 )
 
@@ -18,5 +19,7 @@ func simpleStart(cmd *exec.Cmd) (func(), error) {
 
 func isTerminal(stdin io.Reader) bool {
 	f, ok := stdin.(*os.File)
+
+	log.WithField("argo", true).WithField("ok", ok).WithField("isterm", term.IsTerminal(int(f.Fd()))).Warn("checking term status of stdin")
 	return ok && term.IsTerminal(int(f.Fd()))
 }