Add comment

Signed-off-by: Yuan Tang <[email protected]>
argoproj · Jul 14, 2021 · 95cdcb3 · 95cdcb3
1 parent 5acb471
commit 95cdcb3
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/cmd/argo/commands/cron/create.go b/cmd/argo/commands/cron/create.go
@@ -81,6 +81,9 @@ func CreateCronWorkflows(filePaths []string, cliOpts *cliCreateOpts, submitOpts
 			log.Fatal(err)
 		}
 		cronWf.Spec.WorkflowSpec = newWf.Spec
+		// We have only copied the workflow spec to the cron workflow but not the metadata
+		// that includes name and generateName. Here we copy the metadata to the cron
+		// workflow's metadata and remove the unnecessary and mutually exclusive part.
 		if generateName := newWf.ObjectMeta.GenerateName; generateName != "" {
 			cronWf.ObjectMeta.GenerateName = generateName
 			cronWf.ObjectMeta.Name = ""