fix: Warn if running in TTY on windows

Signed-off-by: Dana Pieluszczak <[email protected]>

cmd/argoexec/commands/emissary.go

@@ -247,7 +247,7 @@ func startCommand(name string, args []string, template *wfv1.Template) (*exec.Cm
 		origCloser()
 	}
 
-	return command, cmdCloser, nil
+	return command, closer, nil
 }
 
 func saveArtifact(srcPath string) error {

workflow/executor/os-specific/command.go

@@ -0,0 +1,17 @@
+package os_specific
+
+import (
+	"io"
+	"os/exec"
+)
+
+func simpleStart(cmd *exec.Cmd, stdout io.Writer, stderr io.Writer) (func(), error) {
+	cmd.Stdout = stdout
+	cmd.Stderr = stderr
+
+	if err := cmd.Start(); err != nil {
+		return nil, err
+	}
+
+	return func() {}, nil
+}

workflow/executor/os-specific/command_unix.go

@@ -1,6 +1,6 @@
-//go:build !windows
-package os_specific
+//go:build linux || darwin
 
+package os_specific
 
 import (
 	"io"
@@ -27,14 +27,7 @@ func StartCommand(cmd *exec.Cmd, stdin *os.File, stdout io.Writer, stderr io.Wri
 		// the group leader already
 		Setpgid(cmd.SysProcAttr)
 
-		cmd.Stdout = stdout
-		cmd.Stderr = stderr
-
-		if err := cmd.Start(); err != nil {
-			return nil, err
-		}
-
-		return closer, nil
+		return simpleStart(cmd, stdout, stderr)
 	}
 
 	ptmx, err := pty.Start(cmd)

workflow/executor/os-specific/command_windows.go

@@ -1,21 +1,19 @@
-//go:build windows
 package os_specific
 
 import (
+	"io"
 	"os"
 	"os/exec"
-	"io"
-)
 
-func StartCommand(cmd *exec.Cmd, stdin *os.File, stdout io.Writer, stderr io.Writer) (func(), error) {
-	closer := func() {}
+	log "github.com/sirupsen/logrus"
+	"golang.org/x/term"
+)
 
-	cmd.Stdout = stdout
-	cmd.Stderr = stderr
+var logger = log.WithField("argo", true)
 
-	if err := cmd.Start(); err != nil {
-		return nil, err
+func StartCommand(cmd *exec.Cmd, stdin *os.File, stdout io.Writer, stderr io.Writer) (func(), error) {
+	if term.IsTerminal(int(stdin.Fd())) {
+		logger.Warn("TTY detected but is not supported on windows")
 	}
-
-	return closer, nil
+	return simpleStart(cmd, stdout, stderr)
 }